Strip comments during the initial read #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d out include and directory statements
manuthambi
reviewed
Feb 15, 2022
| @@ -164,6 +164,18 @@ READCONF: { | |||
| my ($config); | |||
| open( CONF, "<$bootfile" ) || die "(fatal) Can't open $bootfile:$!"; | |||
| while ( $_ = <CONF> ) { # deal with the includes! | |||
|
|
|||
There was a problem hiding this comment.
This doesn't work, because mkrdns directives are placed in named comments, which should not be stripped out.
Also, comments in named.boot start with ;.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out include and directory statements are being processed. This fixes that behavior so all valid bind9 comments can be used in conf files.